Re: [PATCH 1/2] workqueue: debug flushing deadlocks with lockdep

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/05, Ingo Molnar wrote:
> 
> * Oleg Nesterov <[email protected]> wrote:
> 
> > OTOH. Perhaps we can can forbid such a behaviour? Andrew, do you know 
> > any good example of "keventd trying to flush its own queue" ?
> 
> i'd prefer to make the API a little bit stricter: such recursion is 
> nasty. Btw., what mechanism prevents the second instance of 
> run_workqueue() calling into a work->func() again?

Nothing. work->func() can re-schedule itself and then call flush_workqueue().
We have a "morton gets to eat his hat" check in run_workqueue() though.

So I agree with you, such recursion is indeed bad. Can we forbid this?
In that case this patch is even more perfect :)

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux