Re: [PATCH] debug work struct cancel deadlocks with lockdep

[Johannes Berg <johannes@sipsolutions.net>]

On Thu, 2007-07-05 at 11:01 +0200, Peter Zijlstra wrote:

> You could of course make this STATIC_LOCKDEP_MAP_INIT() and place it
> near lockdep_init_map() :-)
> 
> That way it would be clear that changes to either ought to be reflected
> in the other.

Sure. I have to repost anyway :)

How about

+/* both _name and _key must not be NULL */
+#define STATIC_LOCKDEP_MAP_INIT(_name, _key) \
+	{ .name = (_name), .key = (_key), }

That'll still require some #ifdef foo inside workqueue.h but I think
it's cleaner to put just this into lockdep.h

johannes

Attachment: signature.asc
Description: This is a digitally signed message part