Re: [PATCH][isapnp] Fix a potential NULL pointer dereference in isapnp_read_tag()

On 03/07/07, Andrew Morton <[email protected]> wrote:

On Sun, 1 Jul 2007 01:38:31 +0200
Jesper Juhl <[email protected]> wrote:

> The Coverity checker spotted (as bug #809) that we dereference 'type'
> long before we actually test it against NULL in
> drivers/pnp/isapnp/core.c::isapnp_read_tag() - both branches of the
> 'if (tag & 0x80)' dereference type, and since this 'if' is before the test
> against NULL and the return of -1, this will blow up is ever type is NULL.
> This is easy to fix by simply moving the NULL test to the beginning of
> the function.
>

[snip]

dood, look at the callers.  NULL is not possible here.

You are right, there's absolutely no way that we could get a NULL
pointer there - that was sloppy of me :-(

I guess we should just get rid of the check completely.  I'll cook up
a patch for that tomorrow.

--
Jesper Juhl <[email protected]>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH][isapnp] Remove pointless check of 'type' against 0 in isapnp_read_tag()
    • From: Jesper Juhl <[email protected]>

• References:
  • Re: [PATCH][isapnp] Fix a potential NULL pointer dereference in isapnp_read_tag()
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [PATCH][Documentation][resend] Add missing files and dirs to 00-INDEX in Documentation/
• Next by Date: [2.6 patch] remove mm/backing-dev.c:congestion_wait_interruptible()
• Previous by thread: Re: [PATCH][isapnp] Fix a potential NULL pointer dereference in isapnp_read_tag()
• Next by thread: [PATCH][isapnp] Remove pointless check of 'type' against 0 in isapnp_read_tag()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]