Re: [RFC/PATCH] debug workqueue deadlocks with lockdep

* Oleg Nesterov <[email protected]> wrote:

> Now we have a false positive if some time we queue B into that 
> workqueue, and this is not good.
> 
> We can avoid this problem if we put lockdep_map into work_struct, so 
> that wait_on_work() "locks" work->lockdep_map, while flush_workqueue() 
> takes wq->lockdep_map.
> 
> But probably we don't need this right now, at least until we really 
> have a lot of false positives while converting from flush_workqueue() 
> to cancel_work_sync/cancel_delayed_work_sync.

would be nice to map the real dependencies. Adding another lockdep_map 
is really low-cost and the lack of false positives is reassuring.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [RFC/PATCH] debug workqueue deadlocks with lockdep
    • From: Johannes Berg <[email protected]>
  • Re: [RFC/PATCH] debug workqueue deadlocks with lockdep
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: Re: [PATCH] NTP: remove clock_was_set() call to prevent deadlock
• Next by Date: Re: [linux-pm] [PATCH] Remove process freezer from suspend to RAM pathway
• Previous by thread: Re: [RFC/PATCH] debug workqueue deadlocks with lockdep
• Next by thread: Re: [RFC/PATCH] debug workqueue deadlocks with lockdep
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]