Hi Stephen,
On 7/2/07, Stephen Hemminger <[email protected]> wrote:
This driver supports the application buttons on some Fujitsu Lifebook laptops.
These buttons are read via the SMBus, for more details see:
http://apanel.sourceforge.net/tech.php
The buttons are handled as by the regular input system.
Two models are detected now, but other Fujitsu laptop's have
keys that may work similarly.
It is based on the earlier apanel driver done by Jochen Eisenger, but
with many changes. The original driver used ioctl's and a separate
user space program; this version hooks into the input subsystem so
that the normal Gnome/KDE shortcuts work without any userspace
changes.
Thank you very much for updating the patch. I have a couple of requests though:
1. LEDs shoud use the generic led subsystem instead of input layer. I
do not have plans of adding any more LED_XXX constants and I think
that adding any LEDs not directly relating to keyboard state was a
mistake.
2. It would be nice if driver supported changing its keymaps now that
we allow overriding default getkeycode() and setkeycode().
3. Do not aaccess input_dev->private directly. input_set_drvdata() and
input+_getdrvdata shoudl be used.
+static int apanel_event(struct input_dev *dev, unsigned int type,
+ unsigned int code, int value)
+{
+ struct apanel *ap = dev->private;
Also I don't think the above is correct. I think you need the following here:
struct input_polled_dev *polldev = input_get_drvdata(dev);
struct apanal *ap = polldev->private;
4:
+ ipdev->input->cdev.dev = &ap->client.dev;
Please change to "ipdev->input->dev.parent = &ap->client.dev;"
5:
+ ipdev->input->private = ap;
polledev uses input->private for its own purposed, you need to use
ipdev->private.
Thank you.
--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
