Re: [patch 0/6] sys_indirect RFC - sys_indirect introduction

[Davide Libenzi <davidel@xmailserver.org>]

On Sun, 1 Jul 2007, Ulrich Drepper wrote:

> On 6/30/07, Davide Libenzi <davidel@xmailserver.org> wrote:
> > This is how all those overloaded syscalls looks like, BTW:
> > [...]
> > How would you do that with a single shared strcture, w/out adding in all
> > signal paths the knowledge of the structure?
> 
> You said it yourself: each individual wrapper would look like this.
> Generalization really isn't possible, you'll have each wrapper syscall
> looking different.  This means there is no reason to try coming up
> with some overly complicated data structure which would only be useful
> if the processing of that data structure could be centralized.

With the current API design you'd able to easily confine the "pre" code 
inside the "set" function, and the "post" code inside the "unset" 
function. It looks pretty clean to me, and allows to limit the knowledge 
of sys_indirect, the more as possible inside kernel/indirect.c.



- Davide


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/