Re: 2.6.22-rc6-mm1: Xen: WARNING: Absolute relocations present

[Jeremy Fitzhardinge <jeremy@goop.org>]

Eric W. Biederman wrote:
> Jeremy Fitzhardinge <jeremy@goop.org> writes:
>
>   
> > Adrian Bunk wrote:
> >     
> > > <--  snip  -->
> > >
> > > ...
> > >   RELOCS  arch/i386/boot/compressed/vmlinux.relocs
> > > WARNING: Absolute relocations present
> > > Offset     Info     Type     Sym.Value Sym.Name
> > > c0101f80 020c6501   R_386_32 00000000  xen_irq_disable_direct_reloc
> > > c0101f9a 0221ea01   R_386_32 00000000  xen_save_fl_direct_reloc
> > > ...
> > >
> > > <--  snip  -->
> > >
> > >       
> > Hm.  Those are false alarms.  I guess I could do something to hide them, but
> > there's nothing inherently wrong with correctly used abs symbols.  Is there
> > someway to whitelist them?
> >     
>
> Yes.  Just add them to arch/i386/boot/compressed/relocs.c safe_abs_syms.
>   

OK, how's this?

Subject: xen: suppress abs symbol warnings for unused reloc pointers

The Xen code generates some abs symbols which are OK from a relocation
perspective.

Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
Cc: Adrian Bunk <bunk@stusta.de>

---
arch/i386/boot/compressed/relocs.c |    2 ++
1 file changed, 2 insertions(+)

===================================================================
--- a/arch/i386/boot/compressed/relocs.c
+++ b/arch/i386/boot/compressed/relocs.c
@@ -31,6 +31,8 @@ static const char* safe_abs_relocs[] = {
		"__kernel_rt_sigreturn",
		"__kernel_sigreturn",
		"SYSENTER_RETURN",
+		"xen_irq_disable_direct_reloc",
+		"xen_save_fl_direct_reloc",
};

static int is_safe_abs_reloc(const char* sym_name)


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/