Re: [PATCH 3/3] tty_io.c: don't use flush_scheduled_work()

On Sun, 1 Jul 2007 19:37:49 +0400
Oleg Nesterov <[email protected]> wrote:

> I don't know how to test this patch, the ack/nack from maintainer is wanted.
> 
> flush_scheduled_work() is evil and should be avoided. Change tty_set_ldisc()
> and release_dev() to use cancel_delayed_work_sync/cancel_work_sync.
> 
> I am not sure we really need to call do_tty_hangup() when cancel_work_sync()
> returns true, but this matches the current behaviour.
> 
> Also, some whitespace fixes.
> 
> Signed-off-by: Oleg Nesterov <[email protected]>

I'm sorry but the tty layer hangup code is not in a shape to do these
changes. Please leave it alone until the revoke() code in 2.6.2x-mm is
ready for mainstream then we will switch to that and all the mess goes
away.

Its just *too* fragile to touch otherwise, and we've had repeated
breakages from tiny changes in this area.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 3/3] tty_io.c: don't use flush_scheduled_work()
    • From: Oleg Nesterov <[email protected]>

• References:
  • [PATCH 3/3] tty_io.c: don't use flush_scheduled_work()
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: Re: 2.6.22-rc6-mm1: Xen: WARNING: Absolute relocations present
• Next by Date: instrumentation and kprobes really still "EXPERIMENTAL"?
• Previous by thread: [PATCH 3/3] tty_io.c: don't use flush_scheduled_work()
• Next by thread: Re: [PATCH 3/3] tty_io.c: don't use flush_scheduled_work()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]