On Sat, Jun 30, 2007 at 04:59:12AM +0000, Linux Kernel Mailing List wrote:
> Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9f462a1a5de06503fd247186b91d4205ac1cf1ba
> Commit: 9f462a1a5de06503fd247186b91d4205ac1cf1ba
> Parent: a357b8f42e7b85e2522c3ad2b29b685bc28743b4
> Author: Alexey Dobriyan <[email protected]>
> AuthorDate: Thu Jun 28 21:25:31 2007 -0700
> Committer: David S. Miller <[email protected]>
> CommitDate: Thu Jun 28 21:25:31 2007 -0700
>
> [SPARC64]: Add linux/pagemap.h to asm/tlb.h
>
> As seen on sparc64-allnoconfig:
>
> CC arch/sparc64/mm/tlb.o
> In file included from arch/sparc64/mm/tlb.c:19:
> include/asm/tlb.h: In function 'tlb_flush_mmu':
> include/asm/tlb.h:60: warning: implicit declaration of function 'release_pages'
> include/asm/tlb.h: In function 'tlb_remove_page':
> include/asm/tlb.h:92: warning: implicit declaration of function 'page_cache_release'
>
> Signed-off-by: Alexey Dobriyan <[email protected]>
> Signed-off-by: David S. Miller <[email protected]>
> ---
> include/asm-sparc64/tlb.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/asm-sparc64/tlb.h b/include/asm-sparc64/tlb.h
> index 7af1e11..349d1d3 100644
> --- a/include/asm-sparc64/tlb.h
> +++ b/include/asm-sparc64/tlb.h
> @@ -2,6 +2,7 @@
> #define _SPARC64_TLB_H
>
> #include <linux/swap.h>
> +#include <linux/pagemap.h>
> #include <asm/pgalloc.h>
> #include <asm/tlbflush.h>
> #include <asm/mmu_context.h>
How is the guideline these days?
If a header file exists in both linux/ and asm-$(ARCH)/ then always
include the linux/ veriant??
If this is the guideline then the better fix would be to let tlb.c
include the linux/ variant.
But I dunno - it seems to be a bit inconsistent.
Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
