Re: [PATCH 01/17] OMAP: Add TI OMAP framebuffer driver

["Trilok Soni" <soni.trilok@gmail.com>]

Hi Sam,

On 6/26/07, Sam Ravnborg <sam@ravnborg.org> wrote:
> diff --git a/drivers/video/omap/Makefile b/drivers/video/omap/Makefile
> new file mode 100644
> index 0000000..5aa7175
> --- /dev/null
> +++ b/drivers/video/omap/Makefile
> @@ -0,0 +1,10 @@
> +#
> +# Makefile for the new OMAP framebuffer device driver
> +#
> +
> +obj-$(CONFIG_FB_OMAP) += omapfb.o
> +
> +objs-yy := omapfb_main.o
> +
> +omapfb-objs := $(objs-yy)
> +
>
> This looks strangs.
> Please use:
> obj-$(CONFIG_FB_OMAP) += omapfb.o
>
> omapfb-y := omapfb_main.o
>
> Or even better rename your .c file to omapfb.c then
> you only need to use:
> obj-$(CONFIG_FB_OMAP) += omapfb.o

Thanx for the review. I will incorporate your suggestions into the
next update of fb patches.

--
--Trilok Soni
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/