Re: [PATCH 0/17] Add Texas Instruments OMAP LCD driver-v2

["Trilok Soni" <soni.trilok@gmail.com>]

On 6/27/07, Andrew Morton <akpm@linux-foundation.org> wrote:
> On Tue, 26 Jun 2007 18:00:22 +0530
> "Trilok Soni" <soni.trilok@gmail.com> wrote:
>
> > This patch series contains Texas Instruments OMAP LCD framebuffer
> > drivers. This driver is divided into
> >
> > * main omapfb driver, which handles most common functions across
> > processor series, like platform driver registration, ioctl handling,
> > much like fb skeleton.
> >
> > This driver then gets through the callback based on the
> > internal/external lcd controller and panel registered to it based on
> > processor and board. Internal/External LCD controller as per lcd panel
> > data registration is being done in separate files and so does patches.
> >
> > Overall this patches contains framebuffer driver for TI OMAP1
> > (OMAP1510/1610/1710) and OMAP2 (OMAP2420/2430) and external
> > controllers used in Nokia Internal Tablets (N770/N800).
> >
> > These drivers were very well tested on OMAP GIT [1] tree from long
> > time. Most of the code for this driver is written by Imre Deak
> > <imre.deak@solidboot.com>.
>
> It seems churlish to complain about the 10-15 minutes spent reassembling
> the mime mess when so much effort has gone into this work.  But for the
> long-term, pleeeeeeeeze do have a talk with your email setup so that you no
> longer need to send patches as attachments, OK?

Ok. Next time I will either copy the patch to gmail-webmail interface
body or use facility outside our campus office PC in order to use
git-send-email like facility.

> > Also CCed to LKML for wider review, and this v2 went through checkpatch.pl and
> > I have modified the patches to accept most of checkpatch comments.
>
> Maybe you had an old version of checkpatch:
>
> trailing statements should be on next line
> #520: FILE: drivers/video/omap/omapfb_main.c:402:
> +       else switch (var->bits_per_pixel) {
>
> line over 80 characters
> #1136: FILE: drivers/video/omap/omapfb_main.c:1018:
> +static enum omapfb_update_mode omapfb_get_update_mode(struct omapfb_device *fbdev)
>
> do not use assignment in if condition
> #1251: FILE: drivers/video/omap/omapfb_main.c:1133:
> +               if ((r = omapfb_query_plane(fbi, &p.plane_info)) < 0)
>
> do not use assignment in if condition
> #1265: FILE: drivers/video/omap/omapfb_main.c:1147:
> +               if ((r = omapfb_query_mem(fbi, &p.mem_info)) < 0)
>
> do not use assignment in if condition
> #1279: FILE: drivers/video/omap/omapfb_main.c:1161:
> +               if ((r = omapfb_get_color_key(fbdev, &p.color_key)) < 0)
>
> do not use assignment in if condition
> #1535: FILE: drivers/video/omap/omapfb_main.c:1417:
> +       if ((r = device_create_file(fbdev->dev, &dev_attr_caps_num)))
>
> do not use assignment in if condition
> #1538: FILE: drivers/video/omap/omapfb_main.c:1420:
> +       if ((r = device_create_file(fbdev->dev, &dev_attr_caps_text)))
>
> do not use assignment in if condition
> #1541: FILE: drivers/video/omap/omapfb_main.c:1423:
> +       if ((r = sysfs_create_group(&fbdev->dev->kobj, &panel_attr_grp)))
>
> do not use assignment in if condition
> #1544: FILE: drivers/video/omap/omapfb_main.c:1426:
> +       if ((r = sysfs_create_group(&fbdev->dev->kobj, &ctrl_attr_grp)))
>
> do not use assignment in if condition
> #1646: FILE: drivers/video/omap/omapfb_main.c:1528:
> +               if ((r = fbinfo_init(fbdev, fbi)) < 0) {
>
> else should follow close brace
> #2001: FILE: drivers/video/omap/omapfb_main.c:1883:
> +               }
> +               else if (!strncmp(this_opt, "vxres:", 6))
>
> Your patch has style problems, please review.  If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> Plus there are quite a large number of extern declarations in C files,
> which is poor practice, which checkpatch failed to detect (maintainer has
> been notified).

I will address above style problem in next update of patches. Thanx
for the review.

--
--Trilok Soni
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/