Re: [PATCH] slob: poor man's NUMA support.

On Tue, 26 Jun 2007, Andrew Morton wrote:

> > +#ifdef CONFIG_NUMA
> > +	if (node != -1)
> > +		page = alloc_pages_node(node, gfp, order);
> > +	else
> > +#endif
> > +		page = alloc_pages(gfp, order);
> 
> Isn't the above equivalent to a bare
> 
> 	page = alloc_pages_node(node, gfp, order);
> 
> ?

No. alloc_pages follows memory policy. alloc_pages_node does not. One of 
the reasons that I want a new memory policy layer are these kinds of 
strange uses.

> 
> 	if (node < 0
> 
> rather than comparing with -1 exactly.
> 
> On many CPUs it'll save a few bytes of code.

-1 means no node specified and much of the NUMA code compares with -1.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] slob: poor man's NUMA support.
    • From: "Nish Aravamudan" <[email protected]>

• References:
  • [PATCH] slob: poor man's NUMA support.
    • From: Paul Mundt <[email protected]>
  • Re: [PATCH] slob: poor man's NUMA support.
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [Cbe-oss-dev] [patch 3/5] cell: updated driver for DDR2 memory on AXON
• Next by Date: Re: [PATCH try #2] security: Convert LSM into a static interface
• Previous by thread: Re: [PATCH] slob: poor man's NUMA support.
• Next by thread: Re: [PATCH] slob: poor man's NUMA support.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]