Re: [PATCH 1/1] fs-sysfs bugfix of sysfs_hash_and_remove dereferencing before checking for NULL

On Fri, Jun 22, 2007 at 10:13:24AM -0700, Doug Thompson wrote:
> From:	Douglas Thompson <[email protected]>
> 
> In tracking down one of my bugs in using sysfs, I found the kernel doing a NULL de-reference
> in function fs/sysfs/inode.c:sysfs_hash_and_remove(), when I (incorrectly) passed
> in a dentry value of NULL.
> 
> The check for NULL should occur BEFORE the dereference of 'dir'. 
> This patch modifies the sequence and does the check FIRST
> 
> 
> Signed-off-by:	Douglas Thompson <[email protected]>
> ---
> 
> Index: linux-2.6.22-rc4-mm2/fs/sysfs/inode.c

There's been a lot of churn and change in this area and this patch
doens't apply anymore.  Can you try respinning it against the next -mm
release and resending it if it is still needed?

thanks,

greg k-h

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 1/1] fs-sysfs bugfix of sysfs_hash_and_remove dereferencing before checking for NULL
    • From: Doug Thompson <[email protected]>

• Prev by Date: Re: [PATCH] sysfs_buffer: use mutex
• Next by Date: Patent or not patent a new idea
• Previous by thread: [PATCH 1/1] fs-sysfs bugfix of sysfs_hash_and_remove dereferencing before checking for NULL
• Next by thread: The transfer has been effected please contact Rev. Duke Harrison.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]