Re: [PATCH 4/7][TAKE5] support new modes in fallocate

On Jun 25, 2007  19:15 +0530, Amit K. Arora wrote:
> +#define FA_FL_DEALLOC	0x01 /* default is allocate */
> +#define FA_FL_KEEP_SIZE	0x02 /* default is extend/shrink size */
> +#define FA_FL_DEL_DATA	0x04 /* default is keep written data on DEALLOC */

In XFS one of the (many) ALLOC modes is to zero existing data on allocate.
For ext4 all this would mean is calling ext4_ext_mark_uninitialized() on
each extent.  For some workloads this would be much faster than truncate
and reallocate of all the blocks in a file.

In that light, please change the comment to /* default is keep existing data */
so that it doesn't imply this is only for DEALLOC.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 4/7][TAKE5] support new modes in fallocate
    • From: David Chinner <[email protected]>
  • Re: [PATCH 4/7][TAKE5] support new modes in fallocate
    • From: "Amit K. Arora" <[email protected]>

• References:
  • Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc
    • From: David Chinner <[email protected]>
  • Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc
    • From: Suparna Bhattacharya <[email protected]>
  • Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc
    • From: David Chinner <[email protected]>
  • Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc
    • From: "Amit K. Arora" <[email protected]>
  • Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc
    • From: David Chinner <[email protected]>
  • Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc
    • From: Andreas Dilger <[email protected]>
  • Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc
    • From: David Chinner <[email protected]>
  • Re: [PATCH 1/5] fallocate() implementation in i86, x86_64 and powerpc
    • From: Andreas Dilger <[email protected]>
  • [PATCH 0/6][TAKE5] fallocate system call
    • From: "Amit K. Arora" <[email protected]>
  • [PATCH 4/7][TAKE5] support new modes in fallocate
    • From: "Amit K. Arora" <[email protected]>

• Prev by Date: Re: [PATCH] atl1: disable 64bit DMA
• Next by Date: Re: [PATCH -mm] PM: Prevent frozen user mode helpers from failing the freezing of tasks (rev. 2)
• Previous by thread: Re: [PATCH 4/7][TAKE5] support new modes in fallocate
• Next by thread: Re: [PATCH 4/7][TAKE5] support new modes in fallocate
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]