Re: [PATCH try #2] security: Convert LSM into a static interface

James Morris wrote:

Convert LSM into a static interface, as the ability to unload a security module is not required by in-tree users and potentially complicates the overall security architecture.

Hello,

-module_param(debug, bool, 0600);
-MODULE_PARM_DESC(debug, "Debug enabled or not");
+static int __init root_plug_debug(char *str)
+{
+	debug = simple_strtol(str, NULL, 0);
+	return 1;
+}
+__setup("root_plug_debug=", root_plug_debug);

is this necessary? What about just documenting root_plug.{vendor_id,product_id,debug}, so it won't break existing root_plug users (if there are any) ? I thought that typed module_param() is prefered over untyped __setup()...

						Thanks,
							Petr


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH try #2] security: Convert LSM into a static interface
    • From: James Morris <[email protected]>

• References:
  • Re: implement-file-posix-capabilities.patch
    • From: "Serge E. Hallyn" <[email protected]>
  • Re: implement-file-posix-capabilities.patch
    • From: Andrew Morgan <[email protected]>
  • Re: implement-file-posix-capabilities.patch
    • From: "Serge E. Hallyn" <[email protected]>
  • Re: implement-file-posix-capabilities.patch
    • From: James Morris <[email protected]>
  • [PATCH][RFC] security: Convert LSM into a static interface
    • From: James Morris <[email protected]>
  • Re: [PATCH][RFC] security: Convert LSM into a static interface
    • From: Chris Wright <[email protected]>
  • [PATCH try #2] security: Convert LSM into a static interface
    • From: James Morris <[email protected]>

• Prev by Date: Re: [PATCH] get_random_long() and AT_ENTROPY for auxv, kernel 2.6.21.5
• Next by Date: Re: [PATCH][RFC] security: Convert LSM into a static interface
• Previous by thread: [PATCH try #2] security: Convert LSM into a static interface
• Next by thread: Re: [PATCH try #2] security: Convert LSM into a static interface
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]