Re: [patch 1/3] add the fsblock layer

On Sunday June 24, [email protected] wrote:
>  
> +#define PG_blocks		20	/* Page has block mappings */
> +

I've only had a very quick look, but this line looks *very* wrong.
You should be using PG_private.

There should never be any confusion about whether ->private has
buffers or blocks attached as the only routines that ever look in
->private are address_space operations  (or should be.  I think 'NULL'
is sometimes special cased, as in try_to_release_page.  It would be
good to do some preliminary work and tidy all that up).

Why do you think you need PG_blocks?

NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 1/3] add the fsblock layer
    • From: Nick Piggin <[email protected]>

• References:
  • [RFC] fsblock
    • From: Nick Piggin <[email protected]>
  • [patch 1/3] add the fsblock layer
    • From: Nick Piggin <[email protected]>

• Prev by Date: Re: [PATCH] Avoid potential NULL deref in scripts/genksyms/lex.l
• Next by Date: Re: [PATCH 16/16] fix handling of integer constant expressions
• Previous by thread: Re: [patch 1/3] add the fsblock layer
• Next by thread: Re: [patch 1/3] add the fsblock layer
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]