Several of our on-disk filesystems have an ioctl function that already
has indented goto labels. I don't think it's quite worth churning all
of these (working) filesystems to make a style checker happy.
I think it's worse style to be mixing label indentation in a file as it
is to create new "correct" indentation labels. That's why I suggested
using context in the file to determine it rather than absolute rules.
If it is bad coding style that is justified because there is already other bad coding
style to match -- that is not a judgment call for a script to make, but for a real
person to make.
There is no law that says you have to fix 100% of the warnings the script generates,
even if they are valid warnings. You'd just better be ready to justify them is all.
Your justification seems reasonable in this case -- it is worse to mix right and
wrong label indentation vs indenting wrongly but consistently.
Indent consistently wrong and feel happy about it, just don't expect the style
checker to give you a free pass when you perpetuate somebody else's wrong. If we
start down the path of bad coding style always being OK if there is already bad
coding style around it I think that is a slippery slope. There should be some
friction when we perpetuate bad style so there is some incentive to fix the style for
future generations to be able to read our code better.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
