On Wed, Jun 20, 2007 at 01:44:35PM -0700, Randy Dunlap wrote:
> On Wed, 20 Jun 2007 00:52:03 +0200 Andreas Herrmann wrote:
>
> > Fix several build errors with PCMCIA=m && NET_PCMCIA=y:
> >
> > LD .tmp_vmlinux1
> > drivers/built-in.o: In function `nmclan_release':
> > nmclan_cs.c:(.text+0x14026c): undefined reference to `pcmcia_disable_device'
> > ...
> > drivers/built-in.o: In function `exit_xirc2ps_cs':
> > xirc2ps_cs.c:(.exit.text+0x1055): undefined reference to `pcmcia_unregister_driver'
> > make: *** [.tmp_vmlinux1] Error 1
>
> This is interesting. This is a result of the menuconfig changes,
> which made NET_PCMCIA a boolean, and then some tristates depend
> on NET_PCMCIA and the boolean -> tristate dependencies aren't
> specific enough.
>
> Your fix is one way to do it. I'd prefer to make
> NET_PCMCIA a tristate instead, then let its value trickle down
> to the subordinate config symbols.
>
> This probably means that some of the other menuconfig changes
> need to be audited for this "feature."
>
>
> Here is my preferred patch.
> ~~~~~~~~~~
>
> From: Randy Dunlap <[email protected]>
>
> Make NET_PCMCIA a tristate symbol so that net/pcmcia drivers
> are constrained to M when needed.
>
> Signed-off-by: Randy Dunlap <[email protected]>
> ---
> drivers/net/pcmcia/Kconfig | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> --- linux-2.6.22-rc5.orig/drivers/net/pcmcia/Kconfig
> +++ linux-2.6.22-rc5/drivers/net/pcmcia/Kconfig
> @@ -3,14 +3,14 @@
> #
>
> menuconfig NET_PCMCIA
> - bool "PCMCIA network device support"
> + tristate "PCMCIA network device support"
> depends on PCMCIA
Yes this solves the problem.
... and is the preferred variant.
Regards,
Andreas
--
Operating | AMD Saxony Limited Liability Company & Co. KG,
System | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
Research | Register Court Dresden: HRA 4896, General Partner authorized
Center | to represent: AMD Saxony LLC (Wilmington, Delaware, US)
(OSRC) | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
