Re: [PATCH] fix req->cmd == INT cases

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/20/2007 02:24 PM, Jens Axboe wrote:

On Wed, Jun 20 2007, Christoph Hellwig wrote:
On Wed, Jun 20, 2007 at 01:53:32PM +0300, Boaz Harrosh wrote:

 drivers/cdrom/aztcd.c
 drivers/cdrom/cm206.c
 drivers/cdrom/gscd.c
 drivers/cdrom/mcdx.c
 drivers/cdrom/optcd.c
 drivers/cdrom/sjcd.c

These are old cdrom drivers that are broken in various ways and
probably should be killed off aswell.

I agree (with both sentiments), would anyone mind if I just killed them
off?

I wouldn't. As far as I'm concerned everything in drivers/cdrom except viocd.c and cdrom.c itself can go, assuming I'll be allowed to bring back support for the legacy cdrom types I'd still like to have supported -- in the first place mitsumi (mcdx), panasonic (sbpcd) and sony (cdu31a) and perhaps at some point other types if/when I happen across the hardware.

The old drivers serve as a source of hardware information but at least mcdx was broken in so many ways that it only did so at the source level. When I wanted to check throughput with the old driver I actually had to go back as far as 2.0.34 to find a working driver (the old mcd.c, already removed since 2.6.10). 2.0.34 sources are available from kernel.org, and 2.6.22 sources even from my local machine...

mitsumi support is being reworked, that can get reintroduced once the
driver is in a stable state.

... which, by the way, is still waiting on comment from anyone with a clue as to why it makes the machine go boom (easily repeatable when using CFQ, not or not easily when using AS):

http://lkml.org/lkml/2007/6/4/50

Rene.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux