Re: [PATCH] remove usage of memmem from scripts/kallsyms.c

[Mike Frysinger <vapier@gentoo.org>]

On Tuesday 19 June 2007, Satyam Sharma wrote:
> On 6/19/07, Paulo Marques <pmarques@grupopie.com> wrote:
> > The only in-kernel user of "memmem" is scripts/kallsyms.c and it only
> > uses it to find tokens that are 2 bytes in size. It is trivial to
> > replace it with a simple function that finds 2-byte tokens.
> >
> > This should help users from systems that don't have the memmem GNU
> > extension available.
>
> So we could remove the "#define _GNU_SOURCE" at the top
> of scripts/kallsyms.c too, presumably? If not (i.e. if there are
> more GNUisms left in that file anyway), then I'm not sure if we
> really gain by the change.

yes, i believe this is true
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.