Re: [PATCH] remove usage of memmem from scripts/kallsyms.c

On Tuesday 19 June 2007, Satyam Sharma wrote:
> On 6/19/07, Paulo Marques <[email protected]> wrote:
> > The only in-kernel user of "memmem" is scripts/kallsyms.c and it only
> > uses it to find tokens that are 2 bytes in size. It is trivial to
> > replace it with a simple function that finds 2-byte tokens.
> >
> > This should help users from systems that don't have the memmem GNU
> > extension available.
>
> So we could remove the "#define _GNU_SOURCE" at the top
> of scripts/kallsyms.c too, presumably? If not (i.e. if there are
> more GNUisms left in that file anyway), then I'm not sure if we
> really gain by the change.

yes, i believe this is true
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

---

• Follow-Ups:
  • Re: [PATCH] remove usage of memmem from scripts/kallsyms.c
    • From: Paulo Marques <[email protected]>

• References:
  • [PATCH] remove usage of memmem from scripts/kallsyms.c
    • From: Paulo Marques <[email protected]>
  • Re: [PATCH] remove usage of memmem from scripts/kallsyms.c
    • From: "Satyam Sharma" <[email protected]>

• Prev by Date: Re: [PATCH 12/12] acpi: select ACPI_EC for SONY_LAPTOP
• Next by Date: Re: [PATCH 7/12] acpi: fix another compile warning
• Previous by thread: Re: [PATCH] remove usage of memmem from scripts/kallsyms.c
• Next by thread: Re: [PATCH] remove usage of memmem from scripts/kallsyms.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]