Re: [PATCH] create_new_namespaces: fix improper return of NULL

On 06/19, Cedric Le Goater wrote:
>
> Oleg Nesterov wrote:
> > Untested.
> > 
> > dup_mnt_ns() and clone_uts_ns() return NULL on failure. This is wrong,
> > create_new_namespaces() uses ERR_PTR() to catch an error. This means
> > that the subsequent create_new_namespaces() will hit BUG_ON() in
> > copy_mnt_ns() or copy_utsname().
> 
> I sent one just like it :
> 
> 	http://lkml.org/lkml/2007/6/12/142

Ah, thanks.

Your patch is more complete, it also fixes kernel/user_namespace.c (which
I don't see in 2.6.22-rc5). I don't this this fix is urgent, so...

Andrew, please ignore this patch.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] create_new_namespaces: fix improper return of NULL
    • From: Cedric Le Goater <[email protected]>

• References:
  • [PATCH] create_new_namespaces: fix improper return of NULL
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH] create_new_namespaces: fix improper return of NULL
    • From: Cedric Le Goater <[email protected]>

• Prev by Date: Re: This is [Re:] How to improve the quality of the kernel[?].
• Next by Date: Re: [patch 2/2] kprobes x86_64 quick fix mark-ro-data
• Previous by thread: Re: [PATCH] create_new_namespaces: fix improper return of NULL
• Next by thread: Re: [PATCH] create_new_namespaces: fix improper return of NULL
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]