Re: [PATCH] madvise_need_mmap_write() usage

On 6/18/07, Jason Baron <[email protected]> wrote:

On Sat, 16 Jun 2007, Christoph Hellwig wrote:

> On Fri, Jun 15, 2007 at 11:20:31AM -0400, Jason Baron wrote:
> > hi,
> >
> > i was just looking at the new madvise_need_mmap_write() call...can we
> > avoid an extra case statement and function call as follows?
>
> Sounds like a good idea, but please move the assignment out of the
> conditional.
>

ok, here's an updated version:

You should always append the full patch, both the diff and the
rationale, I think. Even though it's quoted above, might make less
work for Andrew to pull in.

Thanks,
Nish
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] madvise_need_mmap_write() usage
    • From: Jason Baron <[email protected]>
  • Re: [PATCH] madvise_need_mmap_write() usage
    • From: Christoph Hellwig <[email protected]>
  • Re: [PATCH] madvise_need_mmap_write() usage
    • From: Jason Baron <[email protected]>

• Prev by Date: Re: [patch 00/26] Current slab allocator / SLUB patch queue
• Next by Date: [PATCH -cfs] Fix cpu_load calculation error
• Previous by thread: Re: [PATCH] madvise_need_mmap_write() usage
• Next by thread: [PATCH 0/2] UML - Two for 2.6.22
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]