Re: [PATCH] mm: More __meminit annotations.

On Mon, Jun 18, 2007 at 02:49:24PM +0900, Yasunori Goto wrote:
> > -static inline unsigned long zone_absent_pages_in_node(int nid,
> > +static inline unsigned long __meminit zone_absent_pages_in_node(int nid,
> >  						unsigned long zone_type,
> >  						unsigned long *zholes_size)
> >  {
> 
> I thought __meminit is not effective for these static functions,
> because they are inlined function. So, it depends on caller's 
> defenition. Is it wrong? 
> 
Ah, that's possible, I hadn't considered that. It seems to be a bit more
obvious what the intention is if it's annotated, especially as this is
the convention that's used by the rest of mm/page_alloc.c. A bit more
consistent, if nothing more.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] mm: More __meminit annotations.
    • From: Yasunori Goto <[email protected]>

• References:
  • [PATCH] mm: More __meminit annotations.
    • From: Paul Mundt <[email protected]>
  • Re: [PATCH] mm: More __meminit annotations.
    • From: Yasunori Goto <[email protected]>

• Prev by Date: Re: [2.6 patch] fix devres_release_all() return value
• Next by Date: [patch] hide cond_syscall behind __KERNEL__ for Blackfin/x86_64
• Previous by thread: Re: [PATCH] mm: More __meminit annotations.
• Next by thread: Re: [PATCH] mm: More __meminit annotations.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]