Re: [patch] make hdrscheck.sh force __asm__ in exported headers

On Monday 18 June 2007, Andrew Morton wrote:
> Also, your changelog sucks:
>
>   This updates scripts/hdrschecks.sh by grepping for asm() constructs and
>   rejecting them in favor of __asm__() in exported headers.
>
> well OK.  But for what reason?  We can see a lot of pain in this patch but
> no gain.  The changelog should tell us what the benefit is, so we can make
> informed tradeoff decisions.

err, should have included the rationale in previous e-mail ...

we want to audit asm/volatile because both constructs will fail in userland 
builds when GNU extensions are turned off (like -std=c99) ... __asm__ and 
__volatile__ will work in both places.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

---

• References:
  • [patch] make hdrscheck.sh force __asm__ in exported headers
    • From: Mike Frysinger <[email protected]>
  • Re: [patch] make hdrscheck.sh force __asm__ in exported headers
    • From: Mike Frysinger <[email protected]>
  • Re: [patch] make hdrscheck.sh force __asm__ in exported headers
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [patch] make hdrscheck.sh force __asm__ in exported headers
• Next by Date: Re: [2.6 patch] fix devres_release_all() return value
• Previous by thread: Re: [patch] make hdrscheck.sh force __asm__ in exported headers
• Next by thread: Re: [patch] make hdrscheck.sh force __asm__ in exported headers
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]