Re: [-mm patch] arch/i386/video/fbdev.c should #include <asm/fb.h>

On Mon, Jun 18, 2007 at 01:42:57AM +0200, Adrian Bunk wrote:
> Every file should include the headers containing the prototypes for
> it's global functions.
> 
> Signed-off-by: Adrian Bunk <[email protected]>
> 
> ---
> --- linux-2.6.22-rc4-mm2/arch/i386/video/fbdev.c.old	2007-06-17 15:48:25.000000000 +0200
> +++ linux-2.6.22-rc4-mm2/arch/i386/video/fbdev.c	2007-06-17 15:48:53.000000000 +0200
> @@ -11,6 +11,8 @@
>  #include <linux/fb.h>
>  #include <linux/pci.h>
>  
> +#include <asm/fb.h>
> +

1) Why not include asm/fb.h from linux/fb.h?
2) Is asm/fb.h an -mm thing? I do not have it in my linus tree.

Note: Ketchup is broken on my ubuntu box so no -mm right now.

	Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- 2.6.22-rc4-mm2
  - From: Andrew Morton <[email protected]>
- [-mm patch] arch/i386/video/fbdev.c should #include <asm/fb.h>
  - From: Adrian Bunk <[email protected]>

Prev by Date: Re: [patch 00/14] Page cache cleanup in anticipation of Large Blocksize support
Next by Date: [PATCH] mm: More __meminit annotations.
Previous by thread: [-mm patch] arch/i386/video/fbdev.c should #include <asm/fb.h>
Next by thread: Re: 2.6.22-rc4-mm2
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]