Re: [PATCH] Fix race condition about network device name allocation

Bonding refers to device after unregistering. This has always been
a dangerous thing. The following UNTESTED should fix the problem.

--- a/drivers/net/bonding/bond_sysfs.c	2007-06-13 15:48:37.000000000 -0700
+++ b/drivers/net/bonding/bond_sysfs.c	2007-06-13 15:49:17.000000000 -0700
@@ -164,9 +164,10 @@ static ssize_t bonding_store_bonds(struc
 				printk(KERN_INFO DRV_NAME
 					": %s is being deleted...\n",
 					bond->dev->name);
-				unregister_netdevice(bond->dev);
+
 				bond_deinit(bond->dev);
 		        	bond_destroy_sysfs_entry(bond);
+				unregister_netdevice(bond->dev);
 				rtnl_unlock();
 				goto out;
 			}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] Fix race condition about network device name allocation
    • From: Jay Vosburgh <[email protected]>

• References:
  • [BUG][PATCH] Fix race condition about network device name allocation
    • From: Kenji Kaneshige <[email protected]>
  • Re: [BUG][PATCH] Fix race condition about network device name allocation
    • From: Stephen Hemminger <[email protected]>
  • Re: [BUG][PATCH] Fix race condition about network device name allocation
    • From: Kenji Kaneshige <[email protected]>
  • [PATCH] Fix race condition about network device name allocation
    • From: Stephen Hemminger <[email protected]>
  • Re: [PATCH] Fix race condition about network device name allocation
    • From: Dan Aloni <[email protected]>

• Prev by Date: Re: [BUG] ptraced process waiting on syscall may return kernel internal errnos
• Next by Date: Re: [RFC] TOMOYO Linux
• Previous by thread: Re: [PATCH] Fix race condition about network device name allocation
• Next by thread: Re: [PATCH] Fix race condition about network device name allocation
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]