Re: [PATCH] Blackfin ethernet driver: on chip ethernet MAC controller driver

[Jeff Garzik <jeff@garzik.org>]

Bryan Wu wrote:
> From: "Wu, Bryan" <bryan.wu@analog.com>
>
> This patch implements the driver necessary use the Analog Devices
> Blackfin processor's on-chip ethernet MAC controller.
>
> Signed-off-by: Bryan Wu <bryan.wu@analog.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
>  drivers/net/Kconfig    |   44 +
>  drivers/net/Makefile   |    1 
>  drivers/net/bfin_mac.c |  981 +++++++++++++++++++++++++++++++++++++++
>  drivers/net/bfin_mac.h |  147 +++++
>  4 files changed, 1173 insertions(+)

Finally got back to this.  Please run this patch through 
scripts/checkpatch.pl (found in latest linux-2.6.git upstream kernel 
tree), and follow most of the recommendations.

Personally I would ignore the lines slightly over 80 columns, but the 
other warnings look like real issues.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/