Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n

On Tue, Jun 12, 2007 at 02:07:18AM +0200, Adrian Bunk wrote:
 
 > I'm getting the following compile error with CONFIG_X86_CMPXCHG64=n 
 > (with -Werror-implicit-function-declaration - otherwise it would be a 
 > link error):

We really should just get that flag into mainline so that it breaks
for people before they submit patches.  We run into this constantly.


Add -Werror-implicit-function-declaration
This makes builds fail sooner if something is implicitly defined instead
of having to wait half an hour for it to fail at the linking stage.

Signed-off-by: Dave Jones <[email protected]>

--- linux-2.6/Makefile~	2007-06-04 16:46:24.000000000 -0400
+++ linux-2.6/Makefile	2007-06-04 16:46:53.000000000 -0400
@@ -313,7 +313,8 @@ LINUXINCLUDE    := -Iinclude \
 CPPFLAGS        := -D__KERNEL__ $(LINUXINCLUDE)
 
 CFLAGS          := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
-                   -fno-strict-aliasing -fno-common
+		   -fno-strict-aliasing -fno-common \
+		   -Werror-implicit-function-declaration
 AFLAGS          := -D__ASSEMBLY__
 
 # Read KERNELRELEASE from include/config/kernel.release (if it exists)

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n
    • From: Andrew Morton <[email protected]>

• References:
  • 2.6.22-rc4-mm2
    • From: Andrew Morton <[email protected]>
  • 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n
    • From: Adrian Bunk <[email protected]>

• Prev by Date: [KJ PATCH] Replacing memcpy(dest,src,PAGE_SIZE) with copy_page(dest,src) in arch/i386/mm/init.c
• Next by Date: Re: libata and legacy ide pcmcia failure
• Previous by thread: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n
• Next by thread: Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]