Re: [PATCH] move the kernel to 16MB for NUMA-Q

[Dave Jones <davej@redhat.com>]

On Mon, Jun 11, 2007 at 09:15:58AM -0700, Andrew Morton wrote:
 > On Mon, 11 Jun 2007 15:32:10 +0100 Andy Whitcroft <apw@shadowen.org> wrote:
 > 
 > > 
 > > We are seeing corruption of the decompressed kernel.  It is suspected
 > > that this is platform specific as it has yet to be seen on any
 > > other x86.  Move the kernel to the 16MB boundary.
 > > 
 > > Signed-off-by: Andy Whitcroft <apw@shadowen.org>
 > > ---
 > > diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig
 > > index 7e1950f..89e6bf4 100644
 > > --- a/arch/i386/Kconfig
 > > +++ b/arch/i386/Kconfig
 > > @@ -817,6 +817,7 @@ config CRASH_DUMP
 > >  
 > >  config PHYSICAL_START
 > >  	hex "Physical address where the kernel is loaded" if (EMBEDDED || CRASH_DUMP)
 > > +	default "0x1000000" if X86_NUMAQ
 > >  	default "0x100000"
 > >  	help
 > >  	  This gives the physical address where the kernel is loaded.
 > 
 > grumble.  If it's a BIOS bug then OK.  But if it is indeed a kernel bug
 > then this patch didn't make it go away and it shall return to haunt us.

FWIW, waay back when (sometime last year if memory serves)
Linus suggested changing the default to 0x1000000 for all x86.
The reasoning was some performance microoptimisation regarding
4MB aligned TLBs iirc.

The details have long since evaded my memory, but as an experiment,
I made the change to the Fedora kernel.  FC5,FC6 and F7 have been
this way for a while now, with no obvious problems. Ditto RHEL5.
We did get some performance numbers at the time of the change,
but they weren't amazing (basically in the noise).
Given it never seemed to actually get worse, I never got around
to reverting it..

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/