Re: [PATCH 1/2] i386: Fix NMI watchdog not reserving its MSRs

At system boot time, the NMI watchdog no longer reserved its MSRs,
allowing other subsystems to mess with them. Fix that.

Signed-off-by: Björn Steinbrink <[email protected]>
---
diff --git a/arch/i386/kernel/cpu/perfctr-watchdog.c b/arch/i386/kernel/cpu/perfctr-watchdog.c
index 2b04c8f..f0b6763 100644
--- a/arch/i386/kernel/cpu/perfctr-watchdog.c
+++ b/arch/i386/kernel/cpu/perfctr-watchdog.c
@@ -614,6 +614,12 @@ int lapic_watchdog_init(unsigned nmi_hz)
 		probe_nmi_watchdog();
 		if (!wd_ops)
 			return -1;
+
+		if (!wd_ops->reserve()) {
+			printk(KERN_ERR
+				"NMI watchdog: cannot reserve perfctrs\n");
+			return -1;
+		}
 	}
 
 	if (!(wd_ops->setup(nmi_hz))) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [1/4] 2.6.22-rc3: known regressions
    • From: Michal Piotrowski <[email protected]>
  • Re: [1/4] 2.6.22-rc3: known regressions
    • From: "Udo A. Steinberg" <[email protected]>
  • [PATCH] Fix interchanged parameters to release_{evntsel,perfctr}_nmi
    • From: Björn Steinbrink <[email protected]>
  • Re: [PATCH] Fix interchanged parameters to release_{evntsel,perfctr}_nmi
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] Fix interchanged parameters to release_{evntsel,perfctr}_nmi
    • From: Ingo Molnar <[email protected]>
  • [PATCH 0/2] i386: Fix two more NMI watchdog bugs
    • From: Björn Steinbrink <[email protected]>

• Prev by Date: Re: blank filenames in /sys/modules, kernel 2.6.21
• Next by Date: Re: [patch 7/8] fdmap v2 - implement sys_socket2
• Previous by thread: [PATCH 0/2] i386: Fix two more NMI watchdog bugs
• Next by thread: Re: [PATCH 2/2] i386: Use the right wrapper to disable the NMI watchdog
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]