Re: [ckrm-tech] Per container statistics (containerstats)

[Balbir Singh <balbir@linux.vnet.ibm.com>]

Balbir Singh wrote:
>>>  	return *(pid_t *)a - *(pid_t *)b;
>>> diff -puN kernel/sched.c~containers-taskstats kernel/sched.c
>>> --- linux-2.6.22-rc2-mm1/kernel/sched.c~containers-taskstats	2007-06-05 17:21:57.000000000 +0530
>>> +++ linux-2.6.22-rc2-mm1-balbir/kernel/sched.c	2007-06-05 17:21:57.000000000 +0530
>>> @@ -4280,11 +4280,13 @@ void __sched io_schedule(void)
>>>  {
>>>  	struct rq *rq = &__raw_get_cpu_var(runqueues);
>>>  
>>> +	delayacct_set_flag(DELAYACCT_PF_BLKIO);
>>>  	delayacct_blkio_start();
>> Would it be suitable and appropriate to embed the delayacct_set_flag() call
>> inside delayacct_blkio_start()?
>>
> 
> Yes, I should have done that, will do.
> 
> 

My last reply was wrong, the flag needs to be set outside so that we know the
context that initiated block I/O. We use this flag to track the time used
by the swap block I/O. 

-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/