On Thu, 2007-06-07 at 16:09 -0700, Andrew Morton wrote: > On Wed, 6 Jun 2007 16:04:07 +0200 > Hans-Christian Egtvedt <[email protected]> wrote: > > > This patch adds support for the built in watchdog in AT32AP700X devices. > > > > Tested on AT32AP7000 and ATSTK1000. > > > > Hardware documentation can be found in the AT32AP7000 datasheet. > > > > ... > > > > +static int __init at32_wdt_probe(struct platform_device *pdev) > > +{ <cut start of _probe> > > + wdt->regs = ioremap(regs->start, regs->end - regs->start + 1); > > I see an ioremap(), but there are no iounmap()s anywhere. Hmm, that would be my fault, please see the attach patch, it should apply clean to -mm after your two -fix{1,2} patches. -- With kind regards, Hans-Christian Egtvedt, siv.ing. (M.Sc.) Applications Engineer - AVR32 System Solutions - Atmel Norway
Attachment:
0001-at32ap700x-wdt-add-missing-iounmap-in-_remove.txt
Description: application/mbox
- Follow-Ups:
- Re: [PATCH 1/1] Watchdog driver for AT32AP700X devices
- From: Hans-Christian Egtvedt <[email protected]>
- Re: [PATCH 1/1] Watchdog driver for AT32AP700X devices
- References:
- [PATCH 1/1] Watchdog driver for AT32AP700X devices
- From: Hans-Christian Egtvedt <[email protected]>
- Re: [PATCH 1/1] Watchdog driver for AT32AP700X devices
- From: Andrew Morton <[email protected]>
- [PATCH 1/1] Watchdog driver for AT32AP700X devices
- Prev by Date: [patch 44/54] IPV6 ROUTE: No longer handle ::/0 specially.
- Next by Date: [patch 53/54] TCP: Use default 32768-61000 outgoing port range in all cases.
- Previous by thread: Re: [PATCH 1/1] Watchdog driver for AT32AP700X devices
- Next by thread: Re: [PATCH 1/1] Watchdog driver for AT32AP700X devices
- Index(es):
 |