Re: [PATCH TRIVIAL] icom whitespace cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Paul Mackerras wrote:
Chris Snook writes:

Clean up whitespace and comments in drivers/serial/icom.c

These changes seem totally unnecessary, as the existing indentation is
according to a commonly-accepted style and is quite reasonable:

I agree with Paul.

@@ -149,23 +149,23 @@ static void free_port_memory(struct icom
 	trace(icom_port, "RET_PORT_MEM", 0);
 	if (icom_port->recv_buf) {
 		pci_free_consistent(dev, 4096, icom_port->recv_buf,
-				    icom_port->recv_buf_pci);
+			icom_port->recv_buf_pci);
 		icom_port->recv_buf = NULL;
 	}
 	if (icom_port->xmit_buf) {
 		pci_free_consistent(dev, 4096, icom_port->xmit_buf,
-				    icom_port->xmit_buf_pci);
+			icom_port->xmit_buf_pci);

etc. etc.  The comment changes I agree on but not most of the other
whitespace changes.
The comment changes are fine with me too.

Also you don't seem to have cc'd the driver author.

Current contacts for the driver are: Ananda ([email protected]) and Wendy ([email protected])

:- Ananda

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux