On Tue, 29 May 2007, Andy Whitcroft wrote:
> As a first step package up the current state of the patch style
> checker and include it in the kernel tree. Add instructions
> suggesting running it on submissions. This adds version v0.01 of
^^^^^
> the checkpatch.pl script.
>
> Signed-off-by: Andy Whitcroft <[email protected]>
> ---
> Ok, here is V2 of the checker. A lot of feedback has been
^^
> --- /dev/null
> +++ b/scripts/checkpatch.pl
> @@ -0,0 +1,595 @@
> +#!/usr/bin/perl -w
> +# (c) 2001, Dave Jones. <[email protected]> (the file handling bit)
> +# (c) 2005, Joel Scohpp <[email protected]> (the ugly bit)
> +# (c) 2007, Andy Whitcroft <[email protected]> (new conditions, test suite, etc)
> +# Licensed under the terms of the GNU GPL License version 2
> +
> +use strict;
> +
> +my $P = $0;
> +
> +my $V = '0.01';
^^^^
So, what's the correct version number? ;-)
Will http://www.codemonkey.org.uk/projects/checkpatch/checkpatch.git/ (hey, a
project with the same name started by the same person???) be merged in?
Below is a small fix for the wrong hardcoded script name
---
Subject: [PATCH] Fix checkpatch.pl name in usage template
Fix checkpatch.pl name in usage template:
- Don't use wrong hardcoded script name
- Strip dirname from command name
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
scripts/checkpatch.pl | 3 ++-
1 files changed, 2 insertions(+), 1 deletion(-)
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -7,6 +7,7 @@
use strict;
my $P = $0;
+$P =~ s@.*/@@g;
my $V = '0.01';
@@ -26,7 +27,7 @@ GetOptions(
my $exit = 0;
if ($#ARGV < 0) {
- print "usage: patchstylecheckemail.pl [options] patchfile\n";
+ print "usage: $P [options] patchfile\n";
print "version: $V\n";
print "options: -q => quiet\n";
print " --no-tree => run without a kernel tree\n";
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
[email protected] ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
