Re: [PATCH -rt] Fix TASKLET_STATE_SCHED WARN_ON()

["Jesper Juhl" <jesper.juhl@gmail.com>]

On 06/06/07, john stultz <johnstul@us.ibm.com> wrote:
> --- 2.6-rt.orig/kernel/softirq.c        2007-06-05 18:30:54.000000000 -0700
> +++ 2.6-rt/kernel/softirq.c     2007-06-05 18:36:44.000000000 -0700
> @@ -544,10 +544,17 @@ static void inline
>  __tasklet_common_schedule(struct tasklet_struct *t, struct tasklet_head *head, unsigned int nr)
>  {
>         if (tasklet_trylock(t)) {
> -               WARN_ON(t->next != NULL);
> -               t->next = head->list;
> -               head->list = t;
> -               raise_softirq_irqoff(nr);
> +               /* We may have been preempted before tasklet_trylock
> +                * and __tasklet_action may have already run.
> +                * So double check the sched bit while the takslet

s/takslet/tasklet/

--
Jesper Juhl <jesper.juhl@gmail.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/