Re: [-mm patch] kernel/sched{,_fair}.c: make code static

On Tue, 5 Jun 2007 23:50:56 +0200 Adrian Bunk <[email protected]> wrote:

> This patch makes some needlessly global code static.
> 
> Signed-off-by: Adrian Bunk <[email protected]>
> 
> ---
> 
> BTW: Please don't #include C files in sched.c

Yeah.

> -long div64_s(s64 divident, unsigned long divisor)
> +static long div64_s(s64 divident, unsigned long divisor)

"divident" does appear to be a word, but I suspect "dividend" was intended.

Why is this function lurking in the CPU scheduler rather than in
lib/somewhere.c?

Doesn't an unsigned divide give the same result as a signed one?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [-mm patch] kernel/sched{,_fair}.c: make code static
    • From: Ingo Molnar <[email protected]>

• References:
  • 2.6.22-rc3-mm1
    • From: Andrew Morton <[email protected]>
  • [-mm patch] kernel/sched{,_fair}.c: make code static
    • From: Adrian Bunk <[email protected]>

• Prev by Date: Re: [PATCH 2.6.21.3] USB: add support for TRU-install and new VID/PIDs to Sierra Wireless driver
• Next by Date: Re: [BUG] 2.6.22-rc3-mm1 remove bluetooth usb adapter caused kmalloc bug
• Previous by thread: [-mm patch] kernel/sched{,_fair}.c: make code static
• Next by thread: Re: [-mm patch] kernel/sched{,_fair}.c: make code static
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]