On Tue, Jun 05, 2007 at 01:24:33PM -0700, Keshavamurthy, Anil S wrote:
> 1 file changed, 65 insertions(+), 19 deletions(-)
>
> Index: linux-2.6.22-rc3/lib/respool.c
> ===================================================================
> --- linux-2.6.22-rc3.orig/lib/respool.c 2007-06-05 12:22:26.000000000 -0700
> +++ linux-2.6.22-rc3/lib/respool.c 2007-06-05 12:58:01.000000000 -0700
> @@ -67,6 +67,7 @@
> {
> unsigned long flags;
> struct list_head *plist = (struct list_head *)vaddr;
> + bool queue_work = 0;
Seems sane to me.
I only have a very minor nit to pick: naming a variable (queue_work)
the same as a public function may cause confusion.
Also, if its a bool you should initialize it to 'true' or 'false'.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects
- From: "Keshavamurthy, Anil S" <[email protected]>
- Re: [Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects
- References:
- [Intel-IOMMU 00/10] Intel IOMMU support
- From: [email protected]
- [Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects
- From: [email protected]
- Re: [Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects
- From: Jeff Garzik <[email protected]>
- Re: [Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects
- From: "Keshavamurthy, Anil S" <[email protected]>
- Re: [Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects
- From: Jeff Garzik <[email protected]>
- Re: [Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects
- From: "Keshavamurthy, Anil S" <[email protected]>
- Re: [Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects
- From: "Keshavamurthy, Anil S" <[email protected]>
- [Intel-IOMMU 00/10] Intel IOMMU support
- Prev by Date: Re: [Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects
- Next by Date: [PATCH] Protection for exploiting null dereference using mmap
- Previous by thread: Re: [Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects
- Next by thread: Re: [Intel-IOMMU 02/10] Library routines for handling pre-allocated pool of objects
- Index(es):
 |