Re: [PATCH] never called printk statement in ide-taskfile.c::wait_drive_not_busy

> On 06/04/2007 10:21 PM, Masatake YAMATO wrote:
> > diff --git a/drivers/ide/ide-taskfile.c b/drivers/ide/ide-taskfile.c
> > index 30175c7..5e05311 100644
> > --- a/drivers/ide/ide-taskfile.c
> > +++ b/drivers/ide/ide-taskfile.c
> > @@ -249,7 +249,7 @@ static u8 wait_drive_not_busy(ide_drive_t *drive)
> >  	while (((stat = hwif->INB(IDE_STATUS_REG)) & BUSY_STAT) && retries--)
> >  		udelay(10);
> >  
> > -	if (!retries)
> > +	if (retries < 0)
> 
> 	if (stat & BUSY_STAT)
> 
> >  		printk(KERN_ERR "%s: drive still BUSY!\n", drive->name);
> >  

Oh, yes.
Giving `retries' both roles: loop counter and condition flag for logging
may not good.


    for (retries = 0; retries < 100; retries++)
    {
	    if ((stat = hwif->INB(IDE_STATUS_REG)) & BUSY_STAT)
	       break;

	    udelay(10);
    }


    if (stat & BUSY_STAT)
	    printk(KERN_ERR "%s: drive still BUSY!\n", drive->name);

Masatake YAMATO
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] never called printk statement in ide-taskfile.c::wait_drive_not_busy
    • From: Bartlomiej Zolnierkiewicz <[email protected]>

• References:
  • [PATCH] never called printk statement in ide-taskfile.c::wait_drive_not_busy
    • From: Masatake YAMATO <[email protected]>
  • Re: [PATCH] never called printk statement in ide-taskfile.c::wait_drive_not_busy
    • From: Chuck Ebbert <[email protected]>

• Prev by Date: [PATCH 3/3] [PATCH x86_64] during VM oom condition, kill all threads in process group
• Next by Date: [PATCH 0/2] intro: make NFSv4 exclusive open calls set and use the bitmask in the reply
• Previous by thread: Re: [PATCH] never called printk statement in ide-taskfile.c::wait_drive_not_busy
• Next by thread: Re: [PATCH] never called printk statement in ide-taskfile.c::wait_drive_not_busy
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]