2.6.22-rc3-mm1: __attribute__((weak)) considered harmful

statistics-infrastructure-make-printk_clock-a-generic-kernel-wide-nsec-resolution.patch 
shows why __attribute__((weak)) is harmful because you don't see if a 
required non-weak implemtation is missing:

In this case, the weak printk_clock() was renamed to timestamp_clock(), 
but the ARM and i386 implementations weren't renamed...

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: 2.6.22-rc3-mm1: __attribute__((weak)) considered harmful
    • From: Andrew Morton <[email protected]>

• References:
  • 2.6.22-rc3-mm1
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: Watchdog API Update
• Next by Date: Re: [patch 1/1] document Acked-by:
• Previous by thread: [-mm patch] fix XEN_BLKDEV_FRONTEND Makefile entry
• Next by thread: Re: 2.6.22-rc3-mm1: __attribute__((weak)) considered harmful
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]