Re: [RFC] tablet buttons driver for fujitsu siemens laptops

[Stephen Hemminger <shemminger@linux-foundation.org>]

On Sat, 2 Jun 2007 02:59:33 +0200
Robert Gerlach <khnz@gmx.de> wrote:

> Hi,
> 
> I have written a driver for the tablet buttons of (some?) Fujitsu Siemens 
> tablet notebook. Can someone please review this (I'm a newbie here).
> 
> Other questions, where should the modification button (fn) handled (kernel- or 
> userspace)? This button should work like stickykey's in gnome (for 
> one-finger-use). Currently, I have a small userspace daemon for this.
> 
> Some models doesn't have a brightness up and down, only a backlight on and off 
> button. What event should reported there.
> 
> Thanks,
> Robert
> 
> 
> #ifdef DEBUG
> #  define debug(m, a...)	printk( KERN_DEBUG   MODULENAME ": " m "\n", ##a)
> #else
> #  define debug(m, a...)	do {} while(0)
> #endif
> 
> #define info(m, a...)	printk( KERN_INFO    MODULENAME ": " m "\n", ##a)
> #define warn(m, a...)	printk( KERN_WARNING MODULENAME ": " m "\n", ##a)
> #define error(m, a...)	printk( KERN_ERR     MODULENAME ": " m "\n", ##a)
>
>

Please don't reinvent
	pr_debug
	pr_info
	pr_warn,...


-- 
Stephen Hemminger <shemminger@linux-foundation.org>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/