Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning

On Fri, 1 Jun 2007, Christoph Lameter wrote:
> 
> Something like this? (Not tested yet just for review):

I'm not seeing the path on the freeing side that silently accepts BADPTR.

It is not ok to derefence BADPTR, but it's obviously ok to _free_ it.

Also, if I read the patch correctly, you _also_ return BADPTR for slabs 
that are too large. No?  That would be wrong - those need to return NULL 
for "out of memory".

(But I only looked at the diff, not at the end result, so it may be that 
all the cases where you changed "return NULL" into "return BADPTR" were 
really just the size-zero ones - it just looked suspicious).

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning
    • From: Christoph Lameter <[email protected]>

• References:
  • [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning
    • From: Srinivasa Ds <[email protected]>
  • Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning
    • From: Srinivasa Ds <[email protected]>
  • Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning
    • From: Jeremy Fitzhardinge <[email protected]>
  • Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning
    • From: Christoph Lameter <[email protected]>
  • Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning
    • From: Andrew Morton <[email protected]>
  • Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning
    • From: Christoph Lameter <[email protected]>
  • Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning
    • From: Andrew Morton <[email protected]>
  • Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning
    • From: Christoph Lameter <[email protected]>
  • Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning
    • From: Andrew Morton <[email protected]>
  • Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning
    • From: Christoph Lameter <[email protected]>
  • Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning
    • From: Linus Torvalds <[email protected]>
  • Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning
    • From: Christoph Lameter <[email protected]>

• Prev by Date: Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning
• Next by Date: Re: megaraid.c, all kernel versions, problem with multi-luns
• Previous by thread: Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning
• Next by thread: Re: [RFC] [PATCH] cpuset operations causes Badness at mm/slab.c:777 warning
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]