Re: [PATCH 4/5] serial: convert early_uart to earlycon for 8250

[Yinghai Lu <Yinghai.Lu@Sun.COM>]

Andrew Morton wrote:
> On Thu, 31 May 2007 14:01:33 -0700
> Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
>
> > Andrew,
> >
> > Please don't drop others if there is problem with this one.
> >
> > YH
> >
> > [PATCH 4/5] serial: convert early_uart to earlycon for 8250
> >
> > +config FIX_EARLYCON_MEM
> > +	bool
> > +	depends on X86
> > +	default y
> > +
>
> It might have been nicer to do this in arch/i386/Kconfig and
> arch/x86_64/Kconfig.  That way we don't end up with a great string of arch
> selectors in non-arch Kconfig files (do "grep SPARC */Kconfig*")
>
> otoh, doing that means that FIX_EARLYCON_MEM doesn't get mentioned in
> drivers/serial/Kconfig and you need to go on a great hunting expedition to
> find out who sets it.

we could extend that to others arch that is support fixmap like
./asm-i386/fixmap.h
./asm-mips/fixmap.h
./asm-parisc/fixmap.h
./asm-sh/fixmap.h
./asm-sparc/fixmap.h
./asm-um/fixmap.h
./asm-x86_64/fixmap.h

so it will be
>> +config FIX_EARLYCON_MEM
>> +	bool
>> +	depends on X86 || MIPS || PARISC || SH || SPARC || UM
>> +	default y
>> +

You you can provide another config like

CONFIG_FIXMAP

YH
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/