Re: [patch 9/9] Scheduler profiling - Use conditional calls

* William Lee Irwin III ([email protected]) wrote:
> On Wed, May 30, 2007 at 10:00:34AM -0400, Mathieu Desnoyers wrote:
> > Use conditional calls with lower d-cache hit in optimized version as a
> > condition for scheduler profiling call.
> [...]
> > +	if (prof_on)
> > +		BUG_ON(cond_call_arm("profile_on"));
> 
> What's the point of this BUG_ON()? The condition is a priori impossible.
> 

Not impossible: hash_add_cond_call() can return -ENOMEM if kmalloc lacks
memory.

Mathieu

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 9/9] Scheduler profiling - Use conditional calls
    • From: William Lee Irwin III <[email protected]>

• References:
  • [patch 0/9] Conditional Calls - for 2.6.22-rc2-mm1
    • From: Mathieu Desnoyers <[email protected]>
  • [patch 9/9] Scheduler profiling - Use conditional calls
    • From: Mathieu Desnoyers <[email protected]>
  • Re: [patch 9/9] Scheduler profiling - Use conditional calls
    • From: William Lee Irwin III <[email protected]>

• Prev by Date: Re: [RFC 1/4] CONFIG_STABLE: Define it
• Next by Date: Re: [RFC 1/4] CONFIG_STABLE: Define it
• Previous by thread: Re: [patch 9/9] Scheduler profiling - Use conditional calls
• Next by thread: Re: [patch 9/9] Scheduler profiling - Use conditional calls
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]