Re: [PATCH 02/06] Use menuconfig objects 4 - ISDN part 2/6 (CONFIG_ISDN_I4L)

[Karsten Keil <kkeil@suse.de>]

On Thu, May 31, 2007 at 06:16:52PM +0200, Tilman Schmidt wrote:
> Am 30.05.2007 21:38 schrieb Jan Engelhardt:
> > --- linux-2.6.22-rc3-git1.orig/drivers/isdn/Kconfig
> > +++ linux-2.6.22-rc3-git1/drivers/isdn/Kconfig
> > @@ -21,9 +21,7 @@ menuconfig ISDN
> >  
> >  if ISDN
> >  
> > -menu "Old ISDN4Linux"
> > -
> > -config ISDN_I4L
> > +menuconfig ISDN_I4L
> >  	tristate "Old ISDN4Linux (obsolete)"
> >  	---help---
> >  	  This driver allows you to use an ISDN-card for networking
> > @@ -44,8 +42,6 @@ if ISDN_I4L
> >  source "drivers/isdn/i4l/Kconfig"
> >  endif
> >  
> > -endmenu
> > -
> >  comment "CAPI subsystem"
> >  
> 
> This results in a rather strange and inconsistent presentation in
> "make xconfig", with ISDN4Linux appearing as a subtree in the left
> pane but CAPI only visible in the right pane after selecting ISDN.
> IMHO it looks much saner like this:
> 
> --- a/drivers/isdn/Kconfig
> +++ b/drivers/isdn/Kconfig
> @@ -21,8 +21,6 @@ menuconfig ISDN
> 
>  if ISDN
> 
> -menu "Old ISDN4Linux"
> -
>  config ISDN_I4L
>  	tristate "Old ISDN4Linux (deprecated)"
>  	---help---
> @@ -44,12 +42,8 @@ if ISDN_I4L
>  source "drivers/isdn/i4l/Kconfig"
>  endif
> 
> -endmenu
> -
> -comment "CAPI subsystem"
> -
>  config ISDN_CAPI
> -	tristate "CAPI2.0 support"
> +	tristate "CAPI 2.0 subsystem"
>  	help
>  	  This provides the CAPI (Common ISDN Application Programming
>  	  Interface, a standard making it easy for programs to access ISDN
> 
> This gives you a single entry in the left pane tree for disabling
> all of ISDN with a single click, and nicely presents all of its
> suboptions in the right pane once you select the tree entry.
> 

I agree.


-- 
Karsten Keil
SuSE Labs
ISDN and VOIP development
SUSE LINUX Products GmbH, Maxfeldstr.5 90409 Nuernberg, GF: Markus Rex, HRB 16746 (AG Nuernberg)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/