Christoph Lameter wrote:
On Wed, 30 May 2007, Randy Dunlap wrote:I'd like to keep print_section around as it also does some other things. Repeating the output formatting at the various call locations will make it difficult to change if you add another whizbang feature.I have no problems with keeping print_section() except that it's not used in the current tree after this patch. :)I have a patch here that I could sent out today if hexdump would work the right way.Please define "the right way."Align the ascii output so that it does not look that ugly.
It's a kernel log file, for crying out loud. It is not formatted. but I'll change it :( -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [PATCH 2/3 -mm] slub: use lib/hexdump
- From: Christoph Lameter <[email protected]>
- Re: [PATCH 2/3 -mm] slub: use lib/hexdump
- References:
- 2.6.22-rc2-mm1
- From: Andrew Morton <[email protected]>
- Re: 2.6.22-rc2-mm1
- From: Michal Piotrowski <[email protected]>
- Re: 2.6.22-rc2-mm1
- From: Christoph Lameter <[email protected]>
- Re: 2.6.22-rc2-mm1
- From: Michal Piotrowski <[email protected]>
- Re: 2.6.22-rc2-mm1
- From: Andrew Morton <[email protected]>
- Re: 2.6.22-rc2-mm1
- From: Christoph Lameter <[email protected]>
- Re: 2.6.22-rc2-mm1
- From: Andrew Morton <[email protected]>
- Re: 2.6.22-rc2-mm1
- From: Christoph Lameter <[email protected]>
- Re: 2.6.22-rc2-mm1
- From: Randy Dunlap <[email protected]>
- Re: 2.6.22-rc2-mm1
- From: Christoph Lameter <[email protected]>
- Re: 2.6.22-rc2-mm1
- From: Ingo Molnar <[email protected]>
- Re: 2.6.22-rc2-mm1
- From: Christoph Lameter <[email protected]>
- Re: 2.6.22-rc2-mm1
- From: Andrew Morton <[email protected]>
- Re: 2.6.22-rc2-mm1
- From: Randy Dunlap <[email protected]>
- Re: 2.6.22-rc2-mm1
- From: Christoph Lameter <[email protected]>
- [PATCH 2/3 -mm] slub: use lib/hexdump
- From: Randy Dunlap <[email protected]>
- Re: [PATCH 2/3 -mm] slub: use lib/hexdump
- From: Christoph Lameter <[email protected]>
- Re: [PATCH 2/3 -mm] slub: use lib/hexdump
- From: Randy Dunlap <[email protected]>
- Re: [PATCH 2/3 -mm] slub: use lib/hexdump
- From: Christoph Lameter <[email protected]>
- 2.6.22-rc2-mm1
- Prev by Date: Re: [PATCH 1/3] hexdump: more output formatting
- Next by Date: Re: Syslets, Threadlets, generic AIO support, v6
- Previous by thread: Re: [PATCH 2/3 -mm] slub: use lib/hexdump
- Next by thread: Re: [PATCH 2/3 -mm] slub: use lib/hexdump
- Index(es):