Re: [patch 2/2] m68k: Discontinuous memory support

On Mon, 28 May 2007 21:16:32 +0200
Geert Uytterhoeven <[email protected]> wrote:

> -#define __page_address(page)	(PAGE_OFFSET + (((page) - mem_map) << PAGE_SHIFT))
> -#define page_to_phys(page)	virt_to_phys((void *)__page_address(page))
> +#ifdef CONFIG_SINGLE_MEMORY_CHUNK
> +#define page_to_phys(page) \
> +	__pa(PAGE_OFFSET + (((page) - pg_data_map[0].node_mem_map) << PAGE_SHIFT))
> +#else
> +#define page_to_phys(page) ({						\
> +	struct pglist_data *pgdat;					\
> +	pgdat = pg_data_table[page_to_nid(page)];			\
> +	page_to_pfn(page) << PAGE_SHIFT;				\
> +})
> +#endif

macros which evaluate their args more than once are dangerous.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [patch 0/2] A few more m68k patches
    • From: Geert Uytterhoeven <[email protected]>
  • [patch 2/2] m68k: Discontinuous memory support
    • From: Geert Uytterhoeven <[email protected]>

• Prev by Date: Re: [BUG] Something goes wrong with timer statistics.
• Next by Date: [RFC][PATCH] Replacing the /proc/<pid|self>/exe symlink code
• Previous by thread: Re: [patch 2/2] m68k: Discontinuous memory support
• Next by thread: stuff ready to be deleted?
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]