Re: dead CONFIG_ variables: net/ipv4/

[David Miller <davem@davemloft.net>]

From: "Robert P. J. Day" <rpjday@mindspring.com>
Date: Wed, 2 May 2007 17:15:01 -0400 (EDT)

> 
>   again, this list contains some CONFIG_ variables that aren't
> technically dead, but *really* should be renamed to not be confused
> with Kconfig variables.  there are, however, legitimately dead ones in
> the following in places:
> 
> $ ../dead_config.sh net/ipv4
> ========== IP_FIB_TRIE_STATS ==========
> net/ipv4/fib_trie.c:#undef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#ifdef CONFIG_IP_FIB_TRIE_STATS
> net/ipv4/fib_trie.c:#endif /*  CONFIG_IP_FIB_TRIE_STATS */

Robert Olsson uses this for statistics collection by turning
that #undef there into a #define and other developers could
use this too.

Therefore I'm reluctant to remove this for now.

> ========== IP_NOSIOCRT ==========
> net/ipv4/fib_frontend.c:#ifndef CONFIG_IP_NOSIOCRT

Definitely bogus, deleted.

> ========== IP_PIMSM ==========
> net/ipv4/ipmr.c:#define CONFIG_IP_PIMSM 1

This one isn't bogus, it is a shorthand and is set when
either CONFIG_IP_PIMSM_V1 or CONFIG_IP_PIMSM_V2 are set.

> ========== IP_ROUTE_PERVASIVE ==========
> net/ipv4/fib_semantics.c:#ifdef CONFIG_IP_ROUTE_PERVASIVE

This seems to be for an intended feature to allow control of
recursive gateway lookups, I'm not touching this one :-)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/