On Tue, 29 May 2007 10:14:35 -0500 <[email protected]> wrote:
>
> Sorry about that. Would it be helpful if I verified that and sent it in
> signed off?
>
Yes please. The question in my mind was "did it add a race": say, the
notifier chain gets called by some external source after we've gone and
reset the device?
>
> -----Original Message-----
> From: Andrew Morton [mailto:[email protected]]
> Sent: Friday, May 25, 2007 5:00 PM
> To: Greg KH
> Cc: Mattia Dongili; Linux Kernel Mailing List; Hayes, Stuart; David
> Brownell; [email protected]
> Subject: Re: [2.6.22-rc1-mm1] ehci-hcd - BUG: scheduling while atomic:
> rmmod/0x00000001/4568
>
> On Fri, 25 May 2007 14:40:05 -0700 Greg KH <[email protected]> wrote:
>
> > On Mon, May 21, 2007 at 11:44:37AM +0900, Mattia Dongili wrote:
> > > Hello,
> > >
> > > with gregkh-usb-usb-ehci-cpufreq-fix.patch removing ehci-hcd causes
> > > the following BUG:
> >
> > Thanks for letting me know.
> >
> > Stuart, any help here?
>
> pretty obvious. cpufreq_unregister_notifier() sleeps, and that patch
> causes it to be called under spinlock.
>
> Something like this...
>
> --- a/drivers/usb/host/ehci-hcd.c~fix-gregkh-usb-usb-ehci-cpufreq-fix
> +++ a/drivers/usb/host/ehci-hcd.c
> @@ -452,14 +452,14 @@ static void ehci_stop (struct usb_hcd *h
> if (HC_IS_RUNNING (hcd->state))
> ehci_quiesce (ehci);
>
> -#ifdef CONFIG_CPU_FREQ
> - cpufreq_unregister_notifier(&ehci->cpufreq_transition,
> - CPUFREQ_TRANSITION_NOTIFIER);
> -#endif
> ehci_reset (ehci);
> ehci_writel(ehci, 0, &ehci->regs->intr_enable);
> spin_unlock_irq(&ehci->lock);
>
> +#ifdef CONFIG_CPU_FREQ
> + cpufreq_unregister_notifier(&ehci->cpufreq_transition,
> + CPUFREQ_TRANSITION_NOTIFIER);
> +#endif
> /* let companion controllers work when we aren't */
> ehci_writel(ehci, 0, &ehci->regs->configured_flag);
>
> _
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
