Hi Stephane, Just a few white space nits. On Tue, 29 May 2007 06:48:15 -0700 Stephane Eranian <[email protected]> wrote: > > diff -urNp --exclude=.git linux-2.6.22.orig/arch/mips/kernel/smp.c linux-2.6.22.base/arch/mips/kernel/smp.c > --- linux-2.6.22.orig/arch/mips/kernel/smp.c 2007-04-25 20:08:32.000000000 -0700 > +++ linux-2.6.22.base/arch/mips/kernel/smp.c 2007-05-29 03:20:21.000000000 -0700 > @@ -203,6 +203,52 @@ void smp_call_function_interrupt(void) > } > } > > +int smp_call_function_single (int cpu, void (*func) (void *info), void *info, int retry, We don't put spaces between the function name and the open parenthesis. > + int wait) > +{ > + struct call_data_struct data; > + int me = smp_processor_id(); > + > + /* > + * Can die spectacularly if this CPU isn't yet marked online > + */ > + BUG_ON(!cpu_online(me)); > + if (cpu == me) { > + WARN_ON(1); > + return -EBUSY; > + } > + > + /* Can deadlock when called with interrupts disabled */ > + WARN_ON(irqs_disabled()); > + > + data.func = func; > + data.info = info; > + atomic_set(&data.started, 0); > + data.wait = wait; > + if (wait) > + atomic_set(&data.finished, 0); > + > + spin_lock(&smp_call_lock); > + call_data = &data; > + mb(); > + > + /* Send a message to the other CPU */ > + core_send_ipi(cpu, SMP_CALL_FUNCTION); > + > + /* Wait for response */ > + /* FIXME: lock-up detection, backtrace on lock-up */ > + while (atomic_read(&data.started) != 1) > + barrier(); > + > + if (wait) > + while (atomic_read(&data.finished) != 1) > + barrier(); > + call_data = NULL; > + spin_unlock(&smp_call_lock); > + > + return 0; > +} Please use tabs for indentation ... > diff -urNp --exclude=.git linux-2.6.22.orig/include/asm-avr32/thread_info.h linux-2.6.22.base/include/asm-avr32/thread_info.h > --- linux-2.6.22.orig/include/asm-avr32/thread_info.h 2007-05-29 03:16:27.000000000 -0700 > +++ linux-2.6.22.base/include/asm-avr32/thread_info.h 2007-05-29 03:20:21.000000000 -0700 > @@ -74,20 +74,18 @@ static inline struct thread_info *curren > * - other flags in MSW > */ > #define TIF_SYSCALL_TRACE 0 /* syscall trace active */ > -#define TIF_NOTIFY_RESUME 1 /* resumption notification requested */ > -#define TIF_SIGPENDING 2 /* signal pending */ > -#define TIF_NEED_RESCHED 3 /* rescheduling necessary */ > -#define TIF_POLLING_NRFLAG 4 /* true if poll_idle() is polling > +#define TIF_SIGPENDING 1 /* signal pending */ > +#define TIF_NEED_RESCHED 2 /* rescheduling necessary */ > +#define TIF_POLLING_NRFLAG 3 /* true if poll_idle() is polling These could be tab indented since you are changing them anyway. And similarly in some of the other files. -- Cheers, Stephen Rothwell [email protected] http://www.canb.auug.org.au/~sfr/
Attachment:
pgpCI2rt9leki.pgp
Description: PGP signature
- References:
- [PATCH 01/22] 2.6.22-rc3 perfmon2: arch-specific infrastructure changes
- From: Stephane Eranian <[email protected]>
- [PATCH 01/22] 2.6.22-rc3 perfmon2: arch-specific infrastructure changes
- Prev by Date: [-mm] Move zlib compression library to common directory
- Next by Date: Re: [1/4] 2.6.22-rc3: known regressions
- Previous by thread: [PATCH 01/22] 2.6.22-rc3 perfmon2: arch-specific infrastructure changes
- Next by thread: Re: [PATCH 01/22] 2.6.22-rc3 perfmon2: arch-specific infrastructure changes
- Index(es):
 |