Re: [patch -mm 1/1] remove useless tolower in isofs

Hi,

And then there's the supercompact form.

while (len--) {
        hash = partial_name_hash(tolower(*name++), hash);
}

But I do not like the last one at all. The first one is the best, because
it clearly separates the condition and iteration parts of the expression,
while STILL being only three lines long. Or two, if you omit the braces.
(But you shouldn't.)

IMO, I like the last one, but I prefer to keep the original author's
one, I only remove the unnecessary tolower function.
What do you think about this , Andrew?

Regards
dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch -mm 1/1] remove useless tolower in isofs
    • From: Andrew Morton <[email protected]>

• References:
  • [patch -mm 1/1] remove useless tolower in isofs
    • From: "young dave" <[email protected]>
  • Re: [patch -mm 1/1] remove useless tolower in isofs
    • From: "John Anthony Kazos Jr." <[email protected]>

• Prev by Date: Re: [RFD] BIO_RW_BARRIER - what it means for devices, filesystems, and dm/md.
• Next by Date: Re: [2.6.21.1] resume doesn't run suspended kernel?
• Previous by thread: Re: [patch -mm 1/1] remove useless tolower in isofs
• Next by thread: Re: [patch -mm 1/1] remove useless tolower in isofs
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]